[TF-4678][Part 2] Sidebar section header and navigation controls - #91
Merged
Merged
Conversation
tddang-linagora
approved these changes
Aug 13, 2026
dab246
force-pushed
the
feature/tf-4678-sidebar-navigation-components
branch
from
August 14, 2026 01:39
06db6b2 to
478ac08
Compare
tddang-linagora
self-requested a review
August 17, 2026 03:06
Member
|
please rebase |
dab246
force-pushed
the
feature/tf-4678-sidebar-navigation-components
branch
from
August 17, 2026 04:33
478ac08 to
a761374
Compare
Member
Author
Member
Author
Done |
hoangdat
reviewed
Aug 17, 2026
Member
|
Dark-mode Compose button borrowed Material's default hover/press tint ( // lib/sidebar/linagora_sidebar_button_styles.dart
overlayColor: WidgetStateProperty.resolveWith((states) {
if (states.contains(WidgetState.pressed)) {
return foreground.withValues(alpha: _pressedOverlayOpacity);
}
if (states.contains(WidgetState.hovered)) {
return foreground.withValues(alpha: _hoverOverlayOpacity);
}
if (states.contains(WidgetState.focused)) {
return foreground.withValues(alpha: _pressedOverlayOpacity);
}
return null;
}),// test/sidebar/linagora_sidebar_button_styles_test.dart
expect(
style.overlayColor?.resolve({WidgetState.hovered}),
foreground.withValues(alpha: 0.08),
reason: 'hovered, $brightness',
); |
Member
Author
Fixed. The hover, pressed, and focused overlays now derive from the button’s resolved foreground instead of Material’s default onPrimary tint. I also added coverage for light and dark themes, including hover, pressed, focused, and disabled states. |
tddang-linagora
approved these changes
Aug 17, 2026
hoangdat
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Related to #4678.
Branch:
feature/tf-4678-sidebar-navigation-components→ basefeature/tf-4678-sidebar-tree-listSection grouping and the navigation control primitives.
LinagoraSidebarSectionHeaderLinagoraSidebarControlLinagoraSidebarButtonStyles— primary sidebar action button styleLinagoraButtonVariant.text(renders aTextButton, exhaustive switches over the enum need a new branch)Dependencies
Demo
Screen.Recording.2026-08-11.at.10.43.59.mov